feat(summary): add Winding Termination section to the magnetic summary#22
Open
gpitel wants to merge 1 commit into
Open
feat(summary): add Winding Termination section to the magnetic summary#22gpitel wants to merge 1 commit into
gpitel wants to merge 1 commit into
Conversation
One read-only entry per connection, grouped by winding (functionalDescription order); start-then-finish, e.g. Start of Primary to Pin 3 / End of Primary to Pin 4. Derived from coil.functionalDescription[w].connections. Adapted to current main theming: PrimeVue tokens (--p-success-rgb) and Bootstrap Icons (bi-plug-fill) instead of the old Bootstrap/FontAwesome vocabulary. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a Winding Termination section to the Magnetic Summary, after the Winding Construction Steps. One read-only entry per connection, grouped by winding (
functionalDescriptionorder); start-then-finish, so each names whether it is the start or end of the winding, the terminal type, and the pin — e.g. "Start of Primary to Pin 3" / "End of Primary to Pin 4". Derived fromcoil.functionalDescription[w].connections.Styled with current PrimeVue tokens (
--p-success-rgb) and Bootstrap Icons (bi-plug-fill).Before / After
Magnetic Summary bottom —
main(Construction Steps flow into the footer) vs this PR, which inserts a new Winding Termination section:Screenshots captured on the pre-refactor theme; the section is unchanged — only the accent color follows the current theme.
🤖 Generated with Claude Code